Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Makie 0.20 #88

Open
ffevotte opened this issue Nov 24, 2023 · 4 comments
Open

Update to Makie 0.20 #88

ffevotte opened this issue Nov 24, 2023 · 4 comments

Comments

@ffevotte
Copy link
Collaborator

It looks like the profile plot must be updated for Makie 0.20, at least to avoid using the deprecated resolution keyword. There are possibly other tweaks to make...

@maltezfaria
Copy link
Owner

I tried it locally and it worked... maybe I was on the wrong version of Makie

I am going to revert the last commit on main, and we can later open a PR to fix this.

@ffevotte
Copy link
Collaborator Author

It's OK for now: it's merely a warning and we can always fix this later. I think we just don't want to release a patch version without fixing this first.

@maltezfaria
Copy link
Owner

@ffevotte
Copy link
Collaborator Author

Yes. The deprecation warning can be seen e.g. here, in cell [10]: https://nbviewer.org/github/maltezfaria/DataFlowTasks.jl/blob/gh-pages/dev/examples/cholesky/cholesky.ipynb

But (1) it works, and (2) I think the warning does not even show up in the documentation pages. So we're fine for now: no need to revert the commit IMO, but no need to rush to a fix either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants