-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Makie 0.20 #88
Comments
I tried it locally and it worked... maybe I was on the wrong version of I am going to revert the last commit on |
It's OK for now: it's merely a warning and we can always fix this later. I think we just don't want to release a patch version without fixing this first. |
Ok. The https://github.com/maltezfaria/DataFlowTasks.jl/actions/runs/6978168705/job/18989110560 |
Yes. The deprecation warning can be seen e.g. here, in cell [10]: https://nbviewer.org/github/maltezfaria/DataFlowTasks.jl/blob/gh-pages/dev/examples/cholesky/cholesky.ipynb But (1) it works, and (2) I think the warning does not even show up in the documentation pages. So we're fine for now: no need to revert the commit IMO, but no need to rush to a fix either. |
It looks like the profile plot must be updated for Makie 0.20, at least to avoid using the deprecated
resolution
keyword. There are possibly other tweaks to make...The text was updated successfully, but these errors were encountered: