Stage

[NicolasSiver]

Hello Guillaume,

First of all, thank you for your work.
I have question/proposition about Stage object. HLS class is very depended on Stage, but It's just a setter.
I recommend to move Stage initialization in more important method. Anyway, with current implementation, library doesn't work without Stage. Or check for Stage could be earlier, before HTTP request to manifest.

[mangui]

yes, I was thinking of making Stage an arg of HLS constructor

[aydinkn]

I got this error for VOD: Error: Playback failed,hls.stage not set, cannot parse TS data !!!,Playback failed

[mangui]

@aydinkn this error has been fixed 3 months back
22127dd
I guess you are using an old release ?

[mangui]

@NicolasSiver about moving Stage initialization in a more important method, like for example as arg of Hls constructor ...
unfortunately it is not always possible to retrieve Stage reference during HLS object instantiation.
for example if you look at flashlsOSMF:

HLS instantiation is performed here: https://github.com/mangui/flashls/blob/dev/src/org/mangui/osmf/plugins/loader/HLSLoaderBase.as#L79
whereas stage retrieval is done here: https://github.com/mangui/flashls/blob/dev/src/org/mangui/osmf/plugins/traits/HLSDisplayObjectTrait.as#L43

as you can see there is no reference to a DisplayObject available in HLSLoaderBase.

[aydinkn]

@mangui I am using latest master (zip download) but I got this error.

[mangui]

@aydink you should use dev branch instead, or any recent release

[NicolasSiver]

unfortunately it is not always possible to retrieve Stage reference during HLS object instantiation.

Yes, from program architecture point of view.

I think you can easily throw Error if stage isn't set at some point? For example, when very first load is requested?

Also stage is a good source of ENTER_FRAME. I saw somewhere in sources timer with zero delay.
Perfectly, it should be 1000/fps ;)