Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOD HLS clip behaviour at the end of the clip #325

Open
zuzzurro opened this issue Jun 30, 2015 · 4 comments
Open

VOD HLS clip behaviour at the end of the clip #325

zuzzurro opened this issue Jun 30, 2015 · 4 comments

Comments

@zuzzurro
Copy link

Hi Guillaume
Our player supports various plugins for playing Smooth, HDS and now HLS. It's pretty difficult to maintain the various implementations aligned and sometimes we discover different behaviours.
In this case when playing a VOD clip what our player does is: at the end of the clip, seek back to 0.
The expected behaviour would be for player to be in pause at position 0. Pause because other plugins pause the video at the end. In the flashls case instead, the player starts playing from 0 becasue it does not pause at the end.
Do you consider your behaviour the correct one?

@mangui
Copy link
Owner

mangui commented Jun 30, 2015

@zuzzurro
I am not quite clear about your question.
flashls itself does not perform any action at the end of a playback. it just fires a playback complete event.
the player glue on top might catch this event and do a seek(0) (eventually in pause state). but this logic is out of the scope of flashls.

@zuzzurro
Copy link
Author

Well, it seems that the Microsoft Smooth Streaming OSMF plugin at least behaves this way.
I would love to understand what the standard logic is supposed to be, either from the documentation or from the OSMF player sources

@zuzzurro
Copy link
Author

Is "HLSEvent.PLAYBACK_COMPLETE" the event you mentioned above?
From the name it seems specific to this plugin, while we would love to have a single solution working across the various versions.

@mangui
Copy link
Owner

mangui commented Jun 30, 2015

ok, you are talking about OSMF.
this event is being listened by flashls OSMF glue


Play Trait will be stopped upon playback complete
related OSMF source code : https://github.com/willwh/osmf/blob/fac113c5fb7d6724992247be39106e1caa00fcfa/framework/OSMF/org/osmf/traits/PlayTrait.as#L173

Time Trait.signalComplete() will be called upon playback complete.

related OSMF source code: https://github.com/willwh/osmf/blob/fac113c5fb7d6724992247be39106e1caa00fcfa/framework/OSMF/org/osmf/traits/TimeTrait.as#L198

then your player is listening to these OSMF events and doing some actions.
there might be some small differences between HLS/HDS/MSS OSMF plugins there that you need to sort out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants