Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOF converter should catch division by zero error when two-theta is zero #38652

Open
RichardWaiteSTFC opened this issue Jan 21, 2025 · 2 comments
Open

TOF converter should catch division by zero error when two-theta is zero #38652

RichardWaiteSTFC opened this issue Jan 21, 2025 · 2 comments
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Induction Straightforward, low risk issues suitable for new starters ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Milestone
Release 6.13

Comments

@RichardWaiteSTFC
Copy link
Contributor

RichardWaiteSTFC commented Jan 21, 2025 •
edited
Loading

Describe the bug
TOF converter should catch division by zero error when two-theta is zero.
Found during manual testing #38634 - but present in v6.11 as well

To Reproduce
(1) Interfaces > Utility > TOF Converter
(2) Select input unit to be Wavelength, Output to be d-spacing
(3) Set scattering angle to be 0

Image

Expected behavior
Would expect error to be caught and a nicer message as done when input number is 0.

Image

Note it does actually work for negative angles, just 0 needs to be caught
@RichardWaiteSTFC RichardWaiteSTFC added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Jan 21, 2025
@sf1919
Copy link
Contributor

sf1919 commented Jan 21, 2025

@RichardWaiteSTFC Does this occur in v6.11?

@RichardWaiteSTFC RichardWaiteSTFC mentioned this issue Jan 21, 2025
Closed
@RichardWaiteSTFC
Copy link
Contributor Author

Yes, sorry I mentioned that in the manual testing issue but not here

@RichardWaiteSTFC RichardWaiteSTFC added the Induction Straightforward, low risk issues suitable for new starters label Jan 21, 2025
@RichardWaiteSTFC RichardWaiteSTFC added this to the Release 6.13 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Induction Straightforward, low risk issues suitable for new starters ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
ISIS Core
Status: No status
Milestone
Release 6.13
Development

No branches or pull requests
2 participants
@sf1919 @RichardWaiteSTFC