Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better check for large numbers in TOF converter #38653

Open
RichardWaiteSTFC opened this issue Jan 21, 2025 · 0 comments
Open

Better check for large numbers in TOF converter #38653

RichardWaiteSTFC opened this issue Jan 21, 2025 · 0 comments
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Induction Straightforward, low risk issues suitable for new starters ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Milestone
Release 6.13

Comments

@RichardWaiteSTFC
Copy link
Contributor

Describe the bug
Found during manual testing #38634 - but present in v6.11 as well.

TOF converter seems to have a check for large numbers, but it looks like some not-quite-as-large numbers can also produce an error.

To Reproduce
(1) Interfaces > Utility > TOF Converter
(2) Select input unit to be Temperature, Output to be Energy (cm^-1)
(3) Set input 1e256
(4) Convert

Image

Expected behavior
Perhaps what is done for 1e600 input which returns inf?

Image
@RichardWaiteSTFC RichardWaiteSTFC added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Induction Straightforward, low risk issues suitable for new starters ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Jan 21, 2025
@RichardWaiteSTFC RichardWaiteSTFC mentioned this issue Jan 21, 2025
Closed
@RichardWaiteSTFC RichardWaiteSTFC added this to the Release 6.13 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Induction Straightforward, low risk issues suitable for new starters ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
ISIS Core
Status: No status
Milestone
Release 6.13
Development

No branches or pull requests
1 participant
@RichardWaiteSTFC