Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mantid launch script opens in the editor on launch #38654

Open
MialLewis opened this issue Jan 21, 2025 · 6 comments · May be fixed by #38669
Open

mantid launch script opens in the editor on launch #38654

MialLewis opened this issue Jan 21, 2025 · 6 comments · May be fixed by #38669
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS macOS Only The issues related to macOS only. Windows Only Only on Windows
Milestone

Comments

@MialLewis
Copy link
Contributor

System: OSX
Install: Conda
Version: release-next nightly (manual testing)

When a conda install of mantid is launched using workbench or mantidworkbench from the terminal, a script of the same name is opened in the editor.

The script contains:

#!/bin/bash /Users/wym92549/mambaforge/envs/mantid_612_test/bin/pythonw

# -*- coding: utf-8 -*-
import re
import sys

from workbench.app.mantidworkbench_launch_wrapper import launch

if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw?|\.exe)?$', '', sys.argv[0])
    sys.exit(launch())

To Reproduce

  1. Install release-next nightly using conda
  2. launch workbench using either workbench or mantidworkbench
  3. observe script open in the editor
@MialLewis MialLewis added the Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) label Jan 21, 2025
@MialLewis
Copy link
Contributor Author

@cailafinn or @SilkeSchomann, could you see if you can replicate this on OSX?

@sf1919
Copy link
Contributor

sf1919 commented Jan 22, 2025

Does this occur in v6.11?

@SilkeSchomann
Copy link
Contributor

Does this occur in v6.11?

I will have a look. I'm just installing Mantid 6.11 on MacOS to look for other regressions.

@SilkeSchomann
Copy link
Contributor

@cailafinn or @SilkeSchomann, could you see if you can replicate this on OSX?

Yes, I can see the same. It does not happen for Mantid 6.11. It was most likely introduced by this PR: #37750

@sf1919 sf1919 added this to the Release 6.12 milestone Jan 22, 2025
@sf1919 sf1919 moved this to Assigned in v6.12 release Jan 22, 2025
@thomashampson thomashampson added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Jan 22, 2025
@thomashampson
Copy link
Contributor

On Windows the following is printed in the terminal after launching:
script "C:\Users\dsc49661\AppData\Local\mambaforge\envs\manual_test_6_12\Scripts\workbench" does not exist

@thomashampson thomashampson added Windows Only Only on Windows macOS Only The issues related to macOS only. labels Jan 22, 2025
@thomashampson
Copy link
Contributor

on Linux it is not an issue

@sf1919 sf1919 moved this from Assigned to In Progress in v6.12 release Jan 22, 2025
@jclarkeSTFC jclarkeSTFC moved this from In Progress to Ready for Review in v6.12 release Jan 22, 2025
@sf1919 sf1919 moved this from Ready for Review to In Progress in v6.12 release Jan 23, 2025
@sf1919 sf1919 moved this from In Progress to Ready for Review in v6.12 release Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS macOS Only The issues related to macOS only. Windows Only Only on Windows
Projects
Status: No status
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

5 participants