Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logos into websites.yml #117

Open
seeeturtle opened this issue Oct 28, 2018 · 2 comments
Open

Move logos into websites.yml #117

seeeturtle opened this issue Oct 28, 2018 · 2 comments
Labels
googlecodein

Comments

@seeeturtle
Copy link
Collaborator

seeeturtle commented Oct 28, 2018 •
edited
Loading

In #114 , the logo file of keybase is defined in websites.yml.
However, before when there was similar problem, we put them into the css file. (like this)
So I think moving all the logo information to websites.yml will be nice.
@kx-chen
Copy link
Contributor

kx-chen commented Oct 28, 2018

Correct me if I'm wrong, but it looks like most of the logos in the CSS have set width and height properties of around 35px (among other properties too). I believe we might need to set .tooltip i and .tooltip img width and height (and other properties) to those values too.

@seeeturtle
Copy link
Collaborator Author

That will make it. And I believe fixed width and height is not a big matter.

@jayvdb jayvdb changed the title Declare logo in websites.yml Move logos into websites.yml Oct 30, 2018
@jayvdb jayvdb mentioned this issue Oct 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
googlecodein
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @seeeturtle @kx-chen