Bugfix/missing timer run #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OdNairy
force-pushed
the
bugfix/missing-timer-run
branch
from
b2aa36c to
93331b7
Compare
OdNairy
requested review from
S2Ler,
azarovalex and
maios
and removed request for
tarigo
OdNairy
force-pushed
the
bugfix/missing-timer-run
branch
from
93331b7 to
f6b0565
Compare
tatiana-yan
approved these changes
Nov 8, 2022
evil159
approved these changes
Nov 8, 2022
maios
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue with missing
MMETimerManagerwhen thestartis called. SDK has a lazy initialization and that's whyMMETimerManagerconstruction was postponed. However, if any client (like Maps SDK) will fire an event just after an object initialization it would lead to missing 180sec events flushing timer.The actual fix is to move
MMETimerManagerinit back to the object construction.According to my metrics, it takes 90-100 nanoseconds to construct and has very little impact on performance.
Instruments report with multiple runs
Fixes CORESDK-1430