Carplay events modified to adhere to server schema. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincethecoder
commented
Oct 9, 2018
vincethecoder
commented
- Updated the carplay event constants to match up with the expected events schema at the server side.
…nts schema at the server side.
akitchen
reviewed
Oct 10, 2018
| @@ -425,6 +425,10 @@ | |||
| #define MMEEventTypeLocalDebug __NS_SYMBOL(MMEEventTypeLocalDebug) | |||
| #endif | |||
|
|
|||
| #ifndef MMEEventTypeOfflineDownload | |||
There was a problem hiding this comment.
What's this about? Is this related to CarPlay events at all?
There was a problem hiding this comment.
No, this is a separate event related to Maps SDK
akitchen
reviewed
Oct 10, 2018
| @@ -829,20 +829,6 @@ @interface MMEEventsManager (Tests) <MMELocationManagerDelegate> | |||
| }); | |||
| }); | |||
|
|
|||
| context(@"when a carplay event is pushed", ^{ | |||
There was a problem hiding this comment.
Why delete this test? It seems it should be updated for the new event name?
There was a problem hiding this comment.
It's no longer needed since the prefix check for navigation already exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.