Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reverse geocode coordinates before making a Directions request. #43

Closed
lxbarth opened this issue Dec 16, 2015 · 2 comments
Closed
Labels

Comments

@lxbarth
Copy link

lxbarth commented Dec 16, 2015

There's something janky going on when clicking to set origin / destination. I assume the code reverse geocodes a location and then updates the location returned? This leads to very weird behavior in areas where our geocoding locations are sparse:

janky

@tristen
Copy link
Member

tristen commented Dec 16, 2015

The error is being compounded with this UI one in #36

@tristen
Copy link
Member

tristen commented Dec 17, 2015

This is a bit of a blunder on my end. The data that supports the geocoder doesn't have address data for South Korea. Because directions/geocoding data don't share parity (i.e this request always returns Seoul and not the address) I shouldn't be piping coordinates to the geocoder first and making a Directions request from the reverse geocoded result of origin and destination.

This is going to take some refactoring but its top priority for v1.1.0

@tristen tristen added this to the v1.1.0 release milestone Dec 17, 2015
@tristen tristen added the bug label Dec 17, 2015
@tristen tristen changed the title Janky Don Dec 17, 2015
@tristen tristen changed the title Don Don't reverse geocode coordinates before making a Directions request. Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants