Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point main in package.json to dist/mapbox-gl-directions.js #63

Closed
tristen opened this issue Apr 26, 2016 · 2 comments
Closed

Point main in package.json to dist/mapbox-gl-directions.js #63

tristen opened this issue Apr 26, 2016 · 2 comments
Labels
bug

Comments

@tristen
Copy link
Member

tristen commented Apr 26, 2016

Babel shouldn't be required in order for clients to use this via Browserify. cc @tadjohnston
@tristen tristen added the bug label Apr 26, 2016
@tb0yd
Copy link

tb0yd commented Jun 14, 2016

Is pointing to dist/ the best solution here? It makes it difficult to debug when minified code is linked in development mode. I am using Webpack, not Browserify.

Is there a fix that would make this project forward-compatible with Babel 6?

@tristen
Copy link
Member Author

tristen commented Jun 28, 2016

atm this fixes a bug. ES6 code should be transpiled to ES5 (which is widely supported) to support any module loader. I'm happy to un-minify what's in dist though.

tristen added a commit that referenced this issue Jun 28, 2016
@tristen
Point main back to pkg and unminify result
3f1c211 
- Closes #63
tristen added a commit that referenced this issue Jun 28, 2016
@tristen
Unminification is unreasonably large
041a752 
Ref #63
tristen added a commit that referenced this issue Jun 29, 2016
@tristen
Un-minify compiled library
90d6ea9 
Now that filesize bloat was tracked down. Ref #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tb0yd @tristen