Remove dropdown suggestions when reversing origin and destination #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhamley
approved these changes
Apr 28, 2020
| @@ -244,6 +244,10 @@ export function reverse() { | |||
| if (state.destination.geometry) dispatch(originPoint(state.destination.geometry.coordinates)); | |||
| if (state.origin.geometry) dispatch(destinationPoint(state.origin.geometry.coordinates)); | |||
| if (state.origin.geometry && state.destination.geometry) dispatch(fetchDirections()); | |||
| const suggestions = document.getElementsByClassName("suggestions"); | |||
| for (var i = 0; i < suggestions.length; i++) { | |||
There was a problem hiding this comment.
is it possible for suggestions to have more than one element in the array?
malwoodsantoro
force-pushed
the
reverse-suggestions
branch
from
0a3f851 to
0373f55
Compare
malwoodsantoro
force-pushed
the
reverse-suggestions
branch
from
0373f55 to
e43b550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
With the current behavior, when reversing origin and destination, dropdown suggestions are displayed again which leads to a confusing UI.
Proposed behavior simply reverses the points (and step-by-step directions) and hides suggestions when reversing.