Defer mapboxgl dependency to runtime #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tmcw
commented
Aug 16, 2016
tmcw
commented
- Removes dependency on mapboxgl.Directions. Vendors that library. This is so that I can fix bugs in it without a new release, and so that the two modules can share modules and avoid build systems messups.
- Removes require-time dependency on mapboxgl. This is not a guarantee with webpack and other systems, and the previous check was broken ( mapboxgl global check will crash #84 ) in both modules ( Plugin not taking the clicked position #53 )
- That's it, trying to make this the smallest possible change required to make mapbox-gl-directions friendly with webpack async loading
|
👍 this is working flawlessly now on both |
This was referenced Aug 17, 2016
|
@tmcw if we can cut a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.