Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to spec default if property function's target property is undefined #24

Closed
wants to merge 6 commits into from

Conversation

lbud
Copy link

@lbud lbud commented Sep 16, 2016

This is an important feature for e.g. buildings styled with

"fill-extrude-height": {
    "stops": [[0, 0], [1000, 1000]]
    "property": "height"
}

Without the ability to fall back to the spec default, features with no height property would extrude to 1000.

(It will also be very important that we land on a solution for mapbox/mapbox-gl-style-spec#480 but, unlike this, not a release blocker IMO.)

@jfirebaugh
Copy link
Contributor

Do we even need to thread the spec default through here, or could evaluating a property function on an undefined property value return undefined, and then upstream code can fill in the spec default?

@lbud
Copy link
Author

lbud commented Sep 16, 2016

@jfirebaugh good question — in thinking about this I realized I can work around this for my current needs as described in mapbox/mapbox-gl-style-spec#480 (comment), so I'd be okay with punting on this either way…

@lucaswoj
Copy link

lucaswoj commented Oct 4, 2016

@lbud Are you planning to work on this PR further or should it be closed?

@mourner
Copy link
Member

mourner commented Dec 16, 2016

Closing as stale for now.

@mourner mourner closed this Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants