Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local geocoder doesn't emit result event #278

Closed
scottsfarley93 opened this issue May 29, 2019 · 2 comments
Closed

Local geocoder doesn't emit result event #278

scottsfarley93 opened this issue May 29, 2019 · 2 comments
Labels
bug

Comments

@scottsfarley93
Copy link

In some cases, the localGeocoder will not emit a result event, which can cause a bad user experience, since the map will not zoom to the selected result.

Steps to replicate:

  1. Fire up this example: https://docs.mapbox.com/mapbox-gl-js/example/forward-geocode-custom-data/
  2. Search for "Park"
  3. Select one of the results
  4. Search for "Park" again
  5. Select a new result -- notice that nothing happens

We should ensure that results from the localGeocoder are triggering all the events they should be.

Note: this bug is present in v4.3.0, and so pre-dates the localGeocoder changes made in #275 and scheduled for v4.4.0 (#277).

\cc @lobenichou
@scottsfarley93 scottsfarley93 mentioned this issue Jun 25, 2019
Closed
@scottsfarley93 scottsfarley93 mentioned this issue Oct 1, 2019
Merged
4 tasks
@scottsfarley93
Copy link
Author

This was fixed in #298 and will be included in the upcoming v4.5.0 release.

@dehghani-mehdi
Copy link
Contributor

@scottsfarley93 when you will release v4.5.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewharvey @dehghani-mehdi @scottsfarley93