Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language switcher feature demo #1502

Closed
tmcw opened this issue Sep 18, 2015 · 9 comments
Closed

Language switcher feature demo #1502

tmcw opened this issue Sep 18, 2015 · 9 comments

Comments

@tmcw
Copy link
Contributor

tmcw commented Sep 18, 2015

It's possible to switch a map's language by using setLayoutProperty with the text-field property. This is amazing. We should make a demo of this.

/cc @lyzidiamond

@tmcw tmcw changed the title Language switcher feature Language switcher feature demo Sep 18, 2015
@tmcw tmcw added the demo label Sep 18, 2015
@lyzidiamond
Copy link
Contributor

Ooh, fancy! @danswick want to tackle this?

@danswick
Copy link
Contributor

Cool, yeah! I'll start on this today.

@danswick
Copy link
Contributor

This is magic. Here's a PR - #1508

@danswick
Copy link
Contributor

From @jfirebaugh:

committed to mb-pages as 7b16674.

@musicformellons
Copy link

@tmcw Could this be picked up maybe?:
mapbox/mapbox-gl-style-spec#362

@lucaswoj
Copy link
Contributor

@musicformellons We are reserving the : character for token defaults. That feature is moving now!

@musicformellons
Copy link

@lucaswoj I am not sure I understand..., (I hope) you mean: until now it was used for token defaults, but it will be available pretty soon?

@lucaswoj
Copy link
Contributor

We reserved the : character for token defaults but are just getting around to implementing that feature (token defaults) now.

We don't plan to change the set of reserved characters but I like the idea of providing a way to escape reserved characters in field names.

Lets discuss syntax at mapbox/mapbox-gl-style-spec#362 and move forward with an implementation once a syntax has been agreed upon.

@musicformellons
Copy link

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants