Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry displays wrong on some zooms #9085

Closed
Eh2406 opened this issue Dec 6, 2019 · 10 comments · Fixed by #9214
Closed

Geometry displays wrong on some zooms #9085

Eh2406 opened this issue Dec 6, 2019 · 10 comments · Fixed by #9214
Assignees
Labels

Comments

@Eh2406
Copy link

Eh2406 commented Dec 6, 2019

mapbox-gl-js version:
1.4.1 and 1.6.0 (did not test older)

browser:
Chrome or Firefox (tested on FF developers edition 71.0b12)

Steps to Trigger Behavior

  1. http://jsfiddle.net/k98habm4/3/
  2. zoom in (or out) on west bloomfield

at some zooms it looks like:
image

at others zooms it looks like:
image

Expected Behavior

That the shape will not change with zoom. And will match what that geojson looks like on http://geojsonlint.com/ (edit: or if the geojson is invalid for some reason then gives an error with why.)

Actual Behavior

Geometry pops in and out.

@Eh2406 Eh2406 changed the title Geomitly displays wrong on some zooms Geometry displays wrong on some zooms Dec 6, 2019
@kkaefer
Copy link
Member

kkaefer commented Dec 9, 2019

/cc @mourner

@arindam1993
Copy link
Contributor

Thanks for the solid reproduction @Eh2406 , this is probably related to #9072 as well.

@mourner mourner self-assigned this Dec 10, 2019
@Eh2406
Copy link
Author

Eh2406 commented Dec 12, 2019

This is pretty evident on a map I am working on. It is one of the things blocking us releasing this map we are excited about. Is there something I (or SEMCOGs customer care rep) can do to help investigate?

@cs09g
Copy link
Contributor

cs09g commented Dec 20, 2019

It happens when there's more than 2 sets of polygon.

@Eh2406
Copy link
Author

Eh2406 commented Dec 30, 2019

@cs09g Yes, I did notice that when there is only one hole in the polygon the problem goes away. Our polygons come with many holes. Is there some way we can use your observation? Or, was it to help track down how to fix the bug?

@mourner
Copy link
Member

mourner commented Jan 3, 2020

This appears to be a bug in Earcut — investigating over at mapbox/earcut#131

@superchad
Copy link

We think we are seeing related issues using the latest version of Earcut. Would you be able to post a cdn link to the latest mapbox gl build so that we can make an example?

@mourner
Copy link
Member

mourner commented Jan 30, 2020

@Eh2406
Copy link
Author

Eh2406 commented Jan 30, 2020

Sorry I didn't see that in the changelog. We will continue our experimentation with that new version.

@bw4sz
Copy link

bw4sz commented Feb 24, 2020

Would this problem also be evident in mapbox studio? I'm having a similiar type issue.

https://gis.stackexchange.com/questions/351470/mapbox-studio-distorts-and-removes-polygons-in-tileset

I'm making a reproducible now. Should I jump into this thread here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants