Remove try/catch in actor.postMessage

[mourner]

Makes actor.postMessage optimizable by V8 and also makes sure we see any errors thrown on postMessage. Not tested in IE yet.

• actually test on IE!

[mourner]

This is also the reason why we didn't notice broken transferables after buffer refactoring: 7e9ff51

[jfirebaugh]

Well, WTF... I am now testing on IE11 and unable to reproduce any issue with Worker.postMessage and transferables. Using the same test case that I tried earlier, IE 11.0.9600.17801 prints "postMessage with array transfer 0".

I'm not sure if MS patched this or what.

[mourner]

Wow. So apparently it does support transferring at least one object? Also, is the Win version the same?

[mourner]

@jfirebaugh OK I'm now trying to recall a conversation about IE11 transferable objects with a friend — as far as I remember, IE11 doesn't support transferable array buffers and the second argument, and it's there for a different purpose — for an array of MessagePort objects, whatever that means.

[jfirebaugh]

@mourner that's what I thought too, but testing is telling me otherwise. Can you replicate?

[mourner]

@jfirebaugh don't have a Windows machine handy atm.

[mourner]

Summoning @danzel here who did the original IE11 PR, any thoughts?

[danzel]

Uh yeah this is weird. MS have been known to patch things in IE11 occasionally though.

The only notes on the original issue I have are here:
#95 (comment)

But it looks like it doesn't cause an error any more from my limited testing, so yay? :)

The MS docs on this are a bit trash for this:
https://msdn.microsoft.com/en-us/library/hh673568(v=vs.85).aspx
Clicking 'postMessage' on here links to the window.postMessage docs, they don't have a set for webWorker.postMessage.

[lucaswoj]

@mourner @jfirebaugh Do we still want to pursue these changes?

[mourner]

@lucaswoj I don't know, IE is a weird beast.

[lucaswoj]

As far as I can tell, all the postMessage quirks discussed in this thread apply to IE10 but not IE11. We only need to support IE11+.

I'm testing this branch on our Windows machine now and everything looks good!

Anything else you'd like to see before 🚢 this @mourner @jfirebaugh?

[jfirebaugh]

Nope. If it works, .