Add workerCount option #2666
Add workerCount option #2666
Conversation
anandthakker
force-pushed
the
worker-count-option
branch
from
fefd395 to
3b59858
Compare
| @@ -58,7 +58,8 @@ | |||
| zoom: 12.5, | |||
| center: [-77.01866, 38.888], | |||
| style: 'mapbox://styles/mapbox/streets-v8', | |||
| hash: true | |||
| hash: true, | |||
| workerCount: 3 | |||
There was a problem hiding this comment.
I don't think we need it set in the debug page — let's leave it to rely on hardwareConcurrency, which most of the browsers used by GL JS developers support. Or we could add but comment out.
There was a problem hiding this comment.
@mourner My thinking was that, if the majority of users have 4 cores, it might actually be beneficial to have developers working under those conditions by default.
There was a problem hiding this comment.
I've been doing a little housecleaning on this debug page to keep it as simple as possible. My intent (we're not there yet) is for this page to be as simple as possible, making it an ideal place to build one-off testing rigs, and to put any persistent specialized testing rigs on other pages (i.e. video.html)
tl;dr 👍 @mourner
Closes #2022
anandthakker
force-pushed
the
worker-count-option
branch
from
3b59858 to
198fb97
Compare
| @@ -97,6 +98,7 @@ var defaultOptions = { | |||
| * @param {number} [options.zoom] The zoom level of the map's initial viewport. | |||
| * @param {number} [options.bearing] The bearing (rotation) of the map's initial viewport measured in degrees counter-clockwise from north. | |||
| * @param {number} [options.pitch] The pitch of the map's initial viewport measured in degrees. | |||
| * @param {number} [options.workerCount=navigator.hardwareConcurrency] The number of WebWorkers the map should use to process vector tile data. | |||
There was a problem hiding this comment.
options.workerCount=navigator.hardwareConcurrency- 1
|
Feel free to 🚢 once you've addressed my comments above! |
|
Looks good! |
Replaces #2655
Also sets workerCount on the debug page to 3, on the theory that a pretty large majority of users have 4 cpus.
Closes #2022