Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Metrics Tracking #8931

Closed
wants to merge 36 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
63667fd
Initial commit of stats gathering
Nov 1, 2019
2c1c842
Fix failing tests and remove unnecessary `performance` wrapper
Nov 1, 2019
b2a7973
Strip performance probes from production build
Nov 1, 2019
2762739
Rollback accidental //@flow annotation
Nov 1, 2019
740f770
First hacky version of automated metrics suite
Nov 5, 2019
fd77dfe
Test with slower pan animation
Nov 6, 2019
91be5ff
Refactor `generateFixtureJson` to take split root and suite paths
Nov 6, 2019
e43f15e
Handle running of refactored metrics suite.
Nov 6, 2019
6878686
Cleanup flow error and accidental checkin of generated file
Nov 6, 2019
2a6c7ec
Fix lint fail due to missing fixtures.json
Nov 6, 2019
c07c805
Merge branch 'master' of github.com:mapbox/mapbox-gl-js into perf-mark
Nov 7, 2019
cbbbbfc
min and max pitch options (#8834)
andrewharvey Nov 7, 2019
364f8a4
Revert performance marks in createStyleLayer
Nov 7, 2019
37eda90
Change maximum of function_stop from 22 to 24 (#8908)
nicholas-l Nov 8, 2019
4a8fe0c
Upgrade @mapbox/gazetteer to v4.0.4 (#8955)
tristen Nov 8, 2019
da00339
Get named export (#8957)
tristen Nov 8, 2019
0abe854
fix codegen unknown type issue (#8959)
ansis Nov 11, 2019
d5248e1
dedup featureMap by moving it to the config set (#8965)
ansis Nov 11, 2019
c8c8753
Merge branch 'perf-mark' of https://github.com/mapbox/mapbox-gl-js in…
Nov 11, 2019
1dbf2c9
Begin integrating with Puppeteer
Nov 11, 2019
65293f7
- Fix pupeteer integrations
Nov 12, 2019
a8e4b42
Fix metrics path
Nov 12, 2019
fc252f1
Cleanup of computed metrics:
Nov 14, 2019
9897c9d
- add timeout to metrics job
Nov 14, 2019
89f8ed2
Fix timeout syntax
Nov 14, 2019
11307fe
Make it headless
Nov 14, 2019
5a276fa
- Fix memory profiling happening after map destroy
Nov 14, 2019
04d703a
Up runs to 5
Nov 15, 2019
84ad6b3
Up runs to 10
Nov 15, 2019
cc11315
Up runs to 15
Nov 15, 2019
05ecd97
Up runs to 20
Nov 16, 2019
83250d7
Test data variablity based on warmup runs
Nov 16, 2019
7ce56bc
Measure run-to-run variance
Nov 16, 2019
bf72ebe
massive fan out of metrics jobs
Nov 18, 2019
249425c
fix spacing
Nov 18, 2019
c37b83a
add alias
Nov 18, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
196 changes: 196 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,126 @@ workflows:
filters:
tags:
only: /.*/
- collect-metrics-one:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-two:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-three:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-four:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-five:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-six:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-seven:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-eight:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-nine:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-ten:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-eleven:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-twelve:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-thirteen:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-fourteen:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-fifteen:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-sixteen:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-seventeen:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-eighteen:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-nineteen:
requires:
- prepare
filters:
tags:
only: /.*/
- collect-metrics-twenty:
requires:
- prepare
filters:
tags:
only: /.*/
- test-render:
requires:
- prepare
Expand Down Expand Up @@ -102,6 +222,22 @@ defaults: &defaults
- image: circleci/node:10.16-browsers
working_directory: ~/mapbox-gl-js

collect-metrics: &collect-metrics
<<: *defaults
steps:
- attach_workspace:
at: .
- run:
environment:
NUM_ACTUAL_RUNS: 10
NUM_WARMUP_RUNS: 10
command: yarn run run-metrics
no_output_timeout: 20m
- store_artifacts:
path: "bench/dist/metrics-summary.json"
- store_artifacts:
path: "bench/dist/metrics-raw.json"

jobs:
prepare:
<<: *defaults
Expand Down Expand Up @@ -198,6 +334,66 @@ jobs:
at: .
- run: yarn run test-unit

collect-metrics-one:
<<: *collect-metrics

collect-metrics-two:
<<: *collect-metrics

collect-metrics-three:
<<: *collect-metrics

collect-metrics-four:
<<: *collect-metrics

collect-metrics-five:
<<: *collect-metrics

collect-metrics-six:
<<: *collect-metrics

collect-metrics-seven:
<<: *collect-metrics

collect-metrics-eight:
<<: *collect-metrics

collect-metrics-nine:
<<: *collect-metrics

collect-metrics-ten:
<<: *collect-metrics

collect-metrics-eleven:
<<: *collect-metrics

collect-metrics-twelve:
<<: *collect-metrics

collect-metrics-thirteen:
<<: *collect-metrics

collect-metrics-fourteen:
<<: *collect-metrics

collect-metrics-fifteen:
<<: *collect-metrics

collect-metrics-sixteen:
<<: *collect-metrics

collect-metrics-seventeen:
<<: *collect-metrics

collect-metrics-eighteen:
<<: *collect-metrics

collect-metrics-nineteen:
<<: *collect-metrics

collect-metrics-twenty:
<<: *collect-metrics

test-render:
<<: *defaults
steps:
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ test/integration/dist/**/*.js
test/integration/dist/**/*.json
.eslintcache
src/style-spec/dist/index.js
bench/dist/**/*.json
bench/dist/**/*.js
_batfish_site
_batfish_tmp
_site
Expand Down
Empty file added bench/dist/.gitkeep
Empty file.
Loading