Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable using Transferables in Safari #9003

Merged
merged 9 commits into from
Nov 21, 2019
Merged

Disable using Transferables in Safari #9003

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e042dc2
Disable array buffer transfers when messaging between worker and main…
kkaefer Nov 20, 2019
6536940
Add contional check for safari to use worker transfer.
Nov 20, 2019
227016f
Add useragent checking for iPadOS, checks for presence of Safari and …
Nov 21, 2019
a11f62a
Fix typos in docs for isSafari
Nov 21, 2019
96ba57e
More docs deets
Nov 21, 2019
54f6630
My nice keyboard is useless
Nov 21, 2019
5f153ba
Add safari detection debug page
Nov 21, 2019
fc95415
Delete accidentally checked-in file
Nov 21, 2019
7c7355c
Fix lint error
Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/util/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,11 +452,12 @@ export function parseCacheControl(cacheControl: string): Object {
let _isSafari = null;

/**
* Retuns true if the when run WebKit derived browsers.
* This is used to work-around a memory-leak in Safari caused by using web-worker transfers.
* Retuns true when run in WebKit derived browsers.
* This is used as a workaround for a memory leak in Safari caused by using Transferable objects to
* transfer data between WebWorker's and the main thread.
* https://github.com/mapbox/mapbox-gl-js/issues/8771
*
* This should be removed once the unerlying safari issue is fixed.
* This should be removed once the underlying Safari issue is fixed.
*
* @private
* @returns {boolean}
Expand Down