From 8b5fe62af4d7ee91213bb31aabe701362863862f Mon Sep 17 00:00:00 2001 From: Asheem Mamoowala Date: Fri, 6 Mar 2020 16:56:05 -0800 Subject: [PATCH 1/5] Specify nove version 8 or 10 --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a8d791b12c6..1f08800521f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,7 +9,7 @@ Install the Xcode Command Line Tools Package xcode-select --install ``` -Install [node.js](https://nodejs.org/) version 4 or greater +Install [node.js](https://nodejs.org/) version 8 or 10 ```bash brew install node ``` @@ -31,7 +31,7 @@ yarn install ### Linux -Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 6 or greater), [GNU Make](http://www.gnu.org/software/make/), and libglew-dev +Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 8 or 10), [GNU Make](http://www.gnu.org/software/make/), and libglew-dev ```bash sudo apt-get update && sudo apt-get install build-essential git nodejs libglew-dev libxi-dev @@ -56,7 +56,7 @@ yarn install ### Windows -Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 4 or greater), [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules). +Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 8 or 10), [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules). Clone the repository ```bash From 38e426fbbef1bd3c9ef4a443478ae42ae51352a4 Mon Sep 17 00:00:00 2001 From: Asheem Mamoowala Date: Mon, 9 Mar 2020 11:05:06 -0700 Subject: [PATCH 2/5] Node v10 only --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1f08800521f..b2d3f59a2bd 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,7 +9,7 @@ Install the Xcode Command Line Tools Package xcode-select --install ``` -Install [node.js](https://nodejs.org/) version 8 or 10 +Install [node.js](https://nodejs.org/) version 10 ```bash brew install node ``` @@ -31,7 +31,7 @@ yarn install ### Linux -Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 8 or 10), [GNU Make](http://www.gnu.org/software/make/), and libglew-dev +Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 10), [GNU Make](http://www.gnu.org/software/make/), and libglew-dev ```bash sudo apt-get update && sudo apt-get install build-essential git nodejs libglew-dev libxi-dev @@ -56,7 +56,7 @@ yarn install ### Windows -Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 8 or 10), [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules). +Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 10), [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules). Clone the repository ```bash From 46b038fa7abb65b813f075be8f93b6b0e007d6a7 Mon Sep 17 00:00:00 2001 From: Asheem Mamoowala Date: Mon, 9 Mar 2020 12:43:41 -0700 Subject: [PATCH 3/5] Update CONTRIBUTING.md Co-Authored-By: Arindam Bose --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b2d3f59a2bd..ad1a5b896c1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,7 +9,7 @@ Install the Xcode Command Line Tools Package xcode-select --install ``` -Install [node.js](https://nodejs.org/) version 10 +Install [node.js](https://nodejs.org/) version ^10.15 ( Minimum 10.15 while sticking only to major version 10.0 ) ```bash brew install node ``` From 02b27f1cb513d1b323bd16eba4fb505d1c0b8c88 Mon Sep 17 00:00:00 2001 From: Asheem Mamoowala Date: Mon, 9 Mar 2020 12:43:50 -0700 Subject: [PATCH 4/5] Update CONTRIBUTING.md Co-Authored-By: Arindam Bose --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ad1a5b896c1..60668ac7df8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -31,7 +31,7 @@ yarn install ### Linux -Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 10), [GNU Make](http://www.gnu.org/software/make/), and libglew-dev +Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version ^10.15), [GNU Make](http://www.gnu.org/software/make/), and libglew-dev ```bash sudo apt-get update && sudo apt-get install build-essential git nodejs libglew-dev libxi-dev From 49b49eebd46911d2bd5abe95221f53d4b269630a Mon Sep 17 00:00:00 2001 From: Asheem Mamoowala Date: Mon, 9 Mar 2020 12:43:58 -0700 Subject: [PATCH 5/5] Update CONTRIBUTING.md Co-Authored-By: Arindam Bose --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 60668ac7df8..9c1dfc3fdc1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -56,7 +56,7 @@ yarn install ### Windows -Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 10), [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules). +Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version ^10.15), [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules). Clone the repository ```bash