Addressed PR feedback

mapbox · Mar 7, 2018 · c3eafed · c3eafed
1 parent bd9e8b6
commit c3eafed
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/include/mbgl/style/filter.hpp b/include/mbgl/style/filter.hpp
@@ -236,7 +236,7 @@ class NotHasIdentifierFilter {
 
 class ExpressionFilter {
 public:
-    std::shared_ptr<expression::Expression> expression;
+    std::shared_ptr<const expression::Expression> expression;
 
     friend bool operator==(const ExpressionFilter& lhs, const ExpressionFilter& rhs) {
         return *(lhs.expression) == *(rhs.expression);
@@ -274,7 +274,7 @@ using FilterBase = variant<
 class Filter : public FilterBase {
 public:
     using FilterBase::FilterBase;
-    bool operator()(expression::EvaluationContext context) const;
+    bool operator()(const expression::EvaluationContext &context) const;
 };
 
 } // namespace style

diff --git a/src/mbgl/style/conversion/filter.cpp b/src/mbgl/style/conversion/filter.cpp
@@ -18,9 +18,13 @@ static bool isExpressionFilter(const Convertible& filter) {
 
     optional<std::string> op = toString(arrayMember(filter, 0));
 
-    if (*op == "has") {
-        auto operand = toString(arrayMember(filter, 1));
-        return arrayLength(filter) >= 2 && operand && *operand != "$id" && *operand != "$type";
+    if (!op) {
+        return false;
+
+    } else if (*op == "has") {
+        if (arrayLength(filter) < 2) return false;
+        optional<std::string> operand = toString(arrayMember(filter, 1));
+        return operand && *operand != "$id" && *operand != "$type";
 
     } else if (*op == "in" || *op == "!in" || *op == "!has" || *op == "none") {
         return false;

diff --git a/src/mbgl/style/filter.cpp b/src/mbgl/style/filter.cpp
@@ -5,7 +5,7 @@
 namespace mbgl {
 namespace style {
 
-bool Filter::operator()(expression::EvaluationContext context) const {
+bool Filter::operator()(const expression::EvaluationContext &context) const {
     return FilterBase::visit(*this, FilterEvaluator { context });
 }