This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Run cross-platform expression tests against NSExpression #11014
Labels
archived
Archived because of inactivity
iOS
Mapbox Maps SDK for iOS
macOS
Mapbox Maps SDK for macOS
runtime styling
tests
Comments
1ec5
added
iOS
akitchen
pushed a commit
that referenced
this issue
Mar 11, 2018
This could be a lot better (WIP) A few crashing cases are blacklisted in the code. [#11014]
|
@1ec5 @anandthakker @fabian-guerra The code in https://github.com/mapbox/mapbox-gl-native/tree/fb-expression-tests-from-js can be used to run the expressions tests from gl-js against the iOS SDK. I suppose we could open a "do not merge" PR as well. Once the branch is checked out simply run the tests against the dynamic framework target in the iOS project to see the results. |
|
The branch above has been PR’d as #11435. |
friedbunny
pushed a commit
that referenced
this issue
Mar 22, 2018
This could be a lot better (WIP) A few crashing cases are blacklisted in the code. [#11014]
akitchen
pushed a commit
that referenced
this issue
Apr 27, 2018
This could be a lot better (WIP) A few crashing cases are blacklisted in the code. [#11014]
|
This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The iOS and macOS test targets should somehow exercise the NSExpression implementation added in #10726 against the cross-platform expression tests in the GL JS submodule.
As a starting point, we could run all the expressions through
+[NSExpression(MGLAdditions) mgl_expressionWithJSONObject:]and-[NSExpression(MGLAdditions) mgl_jsonExpressionObject]to ensure that these methods round-trip without crashing Foundation’s NSExpression parser. As a longer-term effort, we could supplement the test fixtures with Darwin-specific files specifying the expected NSExpression translation of each JSON-formatted expression./cc @akitchen @fabian-guerra @anandthakker
The text was updated successfully, but these errors were encountered: