Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Extend NSExpression with convenience methods #11016

Closed
1ec5 opened this issue Jan 24, 2018 · 1 comment
Closed

Extend NSExpression with convenience methods #11016

1ec5 opened this issue Jan 24, 2018 · 1 comment
Assignees
Labels
feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jan 24, 2018

As a more structured alternative to #11015, we should extend NSExpression with convenience methods and initializers that represent common operations for which #10726 uses the custom function syntax:

NSExpression(forConstantValue: "Old")
     .mgl_appending(NSExpression(forConstantValue: " "))
     .mgl_appending(NSExpression(forConstantValue: "MacDonald"))

This is the most conventional approach, but it’s also very verbose – even moreso in Objective-C – and difficult to use in conjunction with format strings.

#5970 (comment) described essentially the same approach for the MGLStyleValue API that #10726 tore out.

/cc @akitchen @fabian-guerra @jmkiley

@1ec5
Copy link
Contributor Author

1ec5 commented Apr 18, 2018

Fixed in #11278 on the release-boba branch for iOS map SDK v4.0.0 and macOS map SDK v0.7.0.

@1ec5 1ec5 closed this as completed Apr 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Development

No branches or pull requests

2 participants