Color layer property documentation refers to UIColor

[1ec5]

#10726 removed some code that previously switched between NSColor and UIColor based on the platform, so now color-typed style layer properties are documented to take instances of UIColor on both iOS and macOS, instead of UIColor on iOS and NSColor on macOS:

mapbox-gl-native/platform/darwin/src/MGLSymbolStyleLayer.h

Line 1479 in cf5d2ca

* Constant `UIColor` values

The code generation script needs to duplicate color-typed property declarations and their documentation comments and use conditional compilation to switch between the two types.

/cc @jmkiley @fabian-guerra

[1ec5]

Actually, the code is still there, but the issue is that the regular expressions are matching occurrences of “MGLColor” or “UIColor” that occur outside of the documentation comment, in the declaration:

mapbox-gl-native/platform/darwin/scripts/generate-style-code.js

Lines 664 to 668 in cf5d2ca

	// Look for a documentation comment that contains “MGLColor” or “UIColor”
	// and the subsequent function, method, or property declaration. Try not to
	// match greedily.
	return src.replace(/(\/\*\*(?:\*[^\/]|[^*])*?\*\/)(\s*[^;]+?\b(?:MGL|NS|UI)(?:Color|EdgeInsets(?:Zero)?)\b[^;]+?;)/g,
	(match, comment, decl) => {

mapbox-gl-native/platform/darwin/scripts/generate-style-code.js

Lines 681 to 682 in cf5d2ca

	// Do the same for CGVector-typed properties.
	.replace(/(\/\*\*(?:\*[^\/]|[^*])*?\b(?:CGVector|UIEdgeInsets(?:Zero)?)\b[\s\S]*?\*\/)(\s*.+?;)/g,

The migration to NSExpression means that the declared type is just NSExpression *, no longer MGLStyleValue<MGLColor *> *. The regular expressions will need to be rewritten to look for “UIColor” within the comment itself.

[1ec5]

Fixed in #11694 on the release-boba branch for macOS map SDK v0.7.0.