Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

+[NSExpression mgl_expressionWithJSONObject:] doesn’t bridge to Swift as initializer #11612

Closed
1ec5 opened this issue Apr 6, 2018 · 1 comment
Closed

+[NSExpression mgl_expressionWithJSONObject:] doesn’t bridge to Swift as initializer #11612

1ec5 opened this issue Apr 6, 2018 · 1 comment
Assignees
@1ec5
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor Swift Specific to the Swift/Objective-C bridge on iOS or macOS
Milestone
ios-v4.0.0-boba

Comments

@1ec5
Copy link
Contributor

1ec5 commented Apr 6, 2018

+[NSExpression mgl_expressionWithJSONObject:] bridges to Swift as NSExpression.mgl_expression(withJSONObject:) instead of MGLExpression(mglJSONObject:). Similar to the category methods on NSValue in NSValue+MGLAdditions.h, the method should be renamed to +[NSExpression expressionWithMGLJSONObject:]. (If that ends up bridging as NSExpression(mgljsonObject:), then we’ll need an NS_SWIFT_NAME annotation.)

/cc @jmkiley @fabian-guerra
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS refactor macOS Mapbox Maps SDK for macOS Swift Specific to the Swift/Objective-C bridge on iOS or macOS labels Apr 6, 2018
@1ec5 1ec5 added this to the ios-v4.0.0 milestone Apr 6, 2018
@1ec5 1ec5 self-assigned this Apr 12, 2018
@1ec5 1ec5 mentioned this issue Apr 12, 2018
Merged
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 12, 2018

Fixed in #11666 on the release-boba branch for iOS map SDK v4.0.0 and macOS map SDK v0.7.0.

@1ec5 1ec5 closed this as completed Apr 12, 2018
@1ec5 1ec5 mentioned this issue Apr 16, 2018
Merged
3 tasks
@1ec5 1ec5 mentioned this issue Apr 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor Swift Specific to the Swift/Objective-C bridge on iOS or macOS
Projects
None yet
Milestone
ios-v4.0.0-boba
Development

No branches or pull requests
1 participant
@1ec5