Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Icon piles #14764

Closed
LukasPaczos opened this issue May 24, 2019 · 4 comments
Closed

Icon piles #14764

LukasPaczos opened this issue May 24, 2019 · 4 comments
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl feature

Comments

@LukasPaczos
Copy link
Contributor

LukasPaczos commented May 24, 2019

This is a feature request for an option to pass an icon pile as the icon-image property value.

This would allow building composite, data-driven icons. Let's imagine this example built with our current tools:
ezgif com-video-to-gif (42)
The composition is correct, but in the process, we are losing collision detection and the z-index between the elements of composite markers is incorrect because each element is laid out on a separate layer.

Icon piles would allow to drastically decrease the number of allocated bitmaps required to represent various states of features in a source.

@LukasPaczos LukasPaczos added feature Core The cross-platform C++ core, aka mbgl labels May 24, 2019
@asheemmamoowala
Copy link
Contributor

@LukasPaczos Can you elaborate what you mean by icon piles? In your example gif, there are three elements to the composited icon for each POI. Are these elements placed on individual layers and expected to be treated as a single icon for collision detection and z-index?

@LukasPaczos
Copy link
Contributor Author

Are these elements placed on individual layers and expected to be treated as a single icon for collision detection and z-index?

@asheemmamoowala I'm imagining the "icon-image" property accepting an array of expressions evaluating to strings with image IDs, so that we can draw all of the images, one on top of the other, on the same layer. For example:

"icon-image": [
  ["get", "marker-type"],
  ["get", "highlight-type"],
  ["get", "icon-type"]
]

@stale
Copy link

stale bot commented Nov 26, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 26, 2019
@LukasPaczos LukasPaczos reopened this Apr 13, 2020
@stale stale bot removed the archived Archived because of inactivity label Apr 13, 2020
@stale stale bot added the archived Archived because of inactivity label Oct 10, 2020
@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl feature
Projects
None yet
Development

No branches or pull requests

2 participants