Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update Events SDK to include key pinning and crash fixes #12825

Merged
merged 6 commits into from
Sep 5, 2018

Conversation

rclee
Copy link
Contributor

@rclee rclee commented Sep 5, 2018

@rclee rclee added iOS Mapbox Maps SDK for iOS telemetry Integration with Mapbox Telemetry libraries labels Sep 5, 2018
@rclee rclee added this to the ios-v4.5.0 milestone Sep 5, 2018
@rclee rclee self-assigned this Sep 5, 2018
@friedbunny friedbunny modified the milestones: ios-v4.5.0, ios-v4.4.0 Sep 5, 2018
@friedbunny
Copy link
Contributor

friedbunny commented Sep 5, 2018

This PR included nitpick failing because #12710 is a new and unusual step for adding new files to the project.

/cc @kkaefer @1ec5

Copy link
Contributor

@friedbunny friedbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you squash merge, please prefix the commit with [ios].

Copy link
Contributor

@captainbarbosa captainbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssss

@rclee rclee merged commit 15c9ed4 into master Sep 5, 2018
@rclee rclee deleted the rclee-events-update branch September 5, 2018 20:43
friedbunny pushed a commit that referenced this pull request Sep 13, 2018
* Update Events SDK to include key pinning and crash fixes
@friedbunny
Copy link
Contributor

friedbunny commented Sep 13, 2018

Though added to the milestone and cherry-pick project for ios-v4.4.0, this was never cherry-picked to release-frappe and subsequently not released in ios-v4.4.0-beta.1 or ios-v4.4.0.

#12891 cherry-picks this into release-frappe for ios-v4.4.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS telemetry Integration with Mapbox Telemetry libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants