Skip to content
This repository has been archived by the owner on Mar 23, 2019. It is now read-only.

Use pragmas for fill-color and fill-outline-color #3

Merged
merged 2 commits into from
May 27, 2016
Merged

Use pragmas for fill-color and fill-outline-color #3

merged 2 commits into from
May 27, 2016

Conversation

lucaswoj
Copy link

⚠️ breaking changes ⚠️

  • rename outline shaders’ color attribute to outline_color
  • require a precision argument for initialize pragmas as well as define pragmas
  • use pragmas for fill color and outline color

cc @jfirebaugh

Use pragmas for fill-color and fill-outline-color
556b3ec 
BREAKING CHANGE FOR GL_NATIVE:

The outline shaders’ color attribute has been renamed from “color” to
“outline_color”
@lucaswoj lucaswoj mentioned this pull request May 26, 2016
Merged
@jfirebaugh
Copy link
Contributor

Can you add the #ifdefs so that these changes are compatible with gl-native?

@lucaswoj
Copy link
Author

Done. I need to make that a habit.

@lucaswoj lucaswoj merged commit 5d064aa into master May 27, 2016
@lucaswoj lucaswoj deleted the fill-color-property-function branch May 27, 2016 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaswoj @jfirebaugh