Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

Make property names use nouns rather than verbs (for example "rotate" ⇢ "rotation") #201

Closed
jfirebaugh opened this issue Oct 30, 2014 · 4 comments
Closed

Make property names use nouns rather than verbs (for example "rotate" ⇢ "rotation") #201

jfirebaugh opened this issue Oct 30, 2014 · 4 comments
Labels
breaking change

Comments

@jfirebaugh
Copy link
Contributor

Rationale:

  • Properties use nouns wherever possible, not verbs.
  • Match *-rotation-alignment.
@peterqliu
Copy link
Contributor

Feels unwieldy but agree. Do same with translate?

@ajashton
Copy link

There is also a justify -> justification

@lucaswoj lucaswoj changed the title *-rotate ⇢ *-rotation Make property names to use nouns rather than verbs (for example "rotate" ⇢ "rotation") Dec 22, 2016
@lucaswoj lucaswoj changed the title Make property names to use nouns rather than verbs (for example "rotate" ⇢ "rotation") Make property names use nouns rather than verbs (for example "rotate" ⇢ "rotation") Dec 22, 2016
@lucaswoj lucaswoj mentioned this issue Dec 22, 2016
Closed
@tmcw
Copy link
Contributor

tmcw commented Dec 23, 2016

Another benefit to this change is that it'd reduce the difference between the iOS SDK's reinterpretation of properties and the style spec / gl-js's interface to them. It's a breaking change, which is a bummer, but I think it's worthwhile on a fixing-the-system level and also makes good sense.

@1ec5 1ec5 mentioned this issue Dec 23, 2016
Merged
3 tasks
This was referenced Jan 5, 2017
Closed
Closed
@1ec5 1ec5 mentioned this issue Jan 6, 2017
Merged
@lucaswoj lucaswoj mentioned this issue Feb 1, 2017
Closed
@lucaswoj
Copy link

lucaswoj commented Feb 1, 2017

This issue was moved to mapbox/mapbox-gl-js#4082

@lucaswoj lucaswoj closed this as completed Feb 1, 2017
@lucaswoj lucaswoj mentioned this issue Feb 1, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tmcw @jfirebaugh @ajashton @lucaswoj @peterqliu