Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the application to curate and customize floating map buttons #2749

Closed
1ec5 opened this issue Nov 24, 2020 · 0 comments · Fixed by #2763
Closed

Allow the application to curate and customize floating map buttons #2749

1ec5 opened this issue Nov 24, 2020 · 0 comments · Fixed by #2763
Assignees
Labels
feature New feature request. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 24, 2020

We’ve had a number of requests over the years to make the floating map buttons more configurable – to remove a button (#2102), add a button, change the look of a button (#2103), move the buttons to the other side of NavigationViewController, lay them out horizontally (#1139), and so on. It’s already possible to remove the feedback button by setting NavigationViewController.showsReportFeedback, but the other buttons are hard-coded.

CarPlayManager already has a hook for customizing the set of map buttons in CarPlay, via the pass-through carPlayManager(_:mapButtonsCompatibleWith:in:for:) method. A similar method on NavigationViewControllerDelegate would be beneficial for the main screen. We could also adapt the MGLOrnamentPosition approach in mapbox/mapbox-gl-native#13911 to make it easy to move the stack of buttons around.

/cc @mapbox/navigation-ios

@1ec5 1ec5 added feature New feature request. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. labels Nov 24, 2020
@ShanMa1991 ShanMa1991 self-assigned this Dec 1, 2020
@1ec5 1ec5 added this to the v1.3.0 milestone Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants