Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate classes to core navigation #321

Closed
2 of 5 tasks
ericrwolfe opened this issue Jun 30, 2017 · 5 comments
Closed
2 of 5 tasks

Migrate classes to core navigation #321

ericrwolfe opened this issue Jun 30, 2017 · 5 comments

Comments

@ericrwolfe
Copy link
Contributor

ericrwolfe commented Jun 30, 2017

Some of the following classes and logic would be useful to move over to MapboxCoreNavigation from the UI module, to give developers better building blocks for creating custom navigation apps from scratch:

cc @bsudekum @frederoni

@ericrwolfe ericrwolfe added this to the v0.5.0 milestone Jun 30, 2017
@1ec5 1ec5 modified the milestones: v0.6.0, v0.5.0 Jul 9, 2017
@1ec5
Copy link
Contributor

1ec5 commented Jul 9, 2017

We performed the most straightforward parts of this task in #309 and #310. Moving to v0.6.0 for the rest.

@frederoni
Copy link
Contributor

Voice instruction formatting (should be extracted from voice controller)

Requires adding OSRMTextInstructions.swift as a dependency to core navigation.

@ericrwolfe
Copy link
Contributor Author

@frederoni seems like OSRMTextInstructions.swift is already a dependency of Core Navigation, at least in Cocoapods land:

s.dependency "OSRMTextInstructions", "~> 0.2.0"

@1ec5
Copy link
Contributor

1ec5 commented Jul 13, 2017

Heh, that was probably an oversight, but I guess it’s OK to have Core Navigation depend on OSRM Text Instructions. The more important consideration is making Polly an optional dependency somehow, because the AWS dependencies are enormous compared to Core Navigation proper.

@1ec5 1ec5 mentioned this issue Jul 21, 2017
5 tasks
@ericrwolfe ericrwolfe removed this from the v0.6.0-1 milestone Jul 21, 2017
@bsudekum
Copy link
Contributor

The checklist has been moved to core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants