From 1c4b902eae786e3bc28a92f54825caeefdd3747f Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Tue, 26 Nov 2024 14:59:15 -0800 Subject: [PATCH] chore: remove make-dir dependency (#742) --- lib/install.js | 3 +-- lib/package.js | 3 +-- lib/testpackage.js | 3 +-- package-lock.json | 3 ++- package.json | 1 - 5 files changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/install.js b/lib/install.js index 617dd8663..827a2bbd7 100644 --- a/lib/install.js +++ b/lib/install.js @@ -10,7 +10,6 @@ const log = require('npmlog'); const existsAsync = fs.exists || path.exists; const versioning = require('./util/versioning.js'); const napi = require('./util/napi.js'); -const makeDir = require('make-dir'); // for fetching binaries const fetch = require('node-fetch'); const tar = require('tar'); @@ -208,7 +207,7 @@ function install(gyp, argv, callback) { log.info('check', 'checked for "' + binary_module + '" (not found)'); } - makeDir(to).then(() => { + fs.promises.mkdir(to, { recursive: true }).then(() => { const fileName = from.startsWith('file://') && from.slice('file://'.length); if (fileName) { extract_from_local(fileName, to, after_place); diff --git a/lib/package.js b/lib/package.js index 073498469..f8f072c0f 100644 --- a/lib/package.js +++ b/lib/package.js @@ -10,7 +10,6 @@ const log = require('npmlog'); const versioning = require('./util/versioning.js'); const napi = require('./util/napi.js'); const existsAsync = fs.exists || path.exists; -const makeDir = require('make-dir'); const tar = require('tar'); function readdirSync(dir) { @@ -49,7 +48,7 @@ function _package(gyp, argv, callback) { } return false; }; - makeDir(path.dirname(tarball)).then(() => { + fs.promises.mkdir(path.dirname(tarball), { recursive: true }).then(() => { let files = readdirSync(from); const base = path.basename(from); files = files.map((file) => { diff --git a/lib/testpackage.js b/lib/testpackage.js index fab1911b9..29a08a2ba 100644 --- a/lib/testpackage.js +++ b/lib/testpackage.js @@ -12,7 +12,6 @@ const versioning = require('./util/versioning.js'); const napi = require('./util/napi.js'); const testbinary = require('./testbinary.js'); const tar = require('tar'); -const makeDir = require('make-dir'); function testpackage(gyp, argv, callback) { const package_json = gyp.package_json; @@ -28,7 +27,7 @@ function testpackage(gyp, argv, callback) { log.info('install', 'unpacking [' + entry.path + ']'); } - makeDir(to).then(() => { + fs.promises.mkdir(to, { recursive: true }).then(() => { tar.extract({ file: tarball, cwd: to, diff --git a/package-lock.json b/package-lock.json index cdaab2fb5..6b78578ac 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,7 +11,6 @@ "dependencies": { "detect-libc": "^2.0.0", "https-proxy-agent": "^5.0.0", - "make-dir": "^3.1.0", "node-fetch": "^2.6.7", "nopt": "^7.2.1", "npmlog": "^7.0.1", @@ -4261,6 +4260,7 @@ "version": "3.1.0", "resolved": "https://registry.npmjs.org/make-dir/-/make-dir-3.1.0.tgz", "integrity": "sha512-g3FeP20LNwhALb/6Cz6Dd4F2ngze0jz7tbzrD2wAV+o9FeNHe4rL+yK2md0J/fiSf1sa1ADhXqi5+oVwOM/eGw==", + "dev": true, "license": "MIT", "dependencies": { "semver": "^6.0.0" @@ -4276,6 +4276,7 @@ "version": "6.3.1", "resolved": "https://registry.npmjs.org/semver/-/semver-6.3.1.tgz", "integrity": "sha512-BR7VvDCVHO+q2xBEWskxS6DJE1qRnb7DxzUrogb71CWoSficBxYsiAGd+Kl0mmq/MprG9yArRkyrQxTO6XjMzA==", + "dev": true, "license": "ISC", "bin": { "semver": "bin/semver.js" diff --git a/package.json b/package.json index 4e554eb3f..f3369141a 100644 --- a/package.json +++ b/package.json @@ -25,7 +25,6 @@ "dependencies": { "detect-libc": "^2.0.0", "https-proxy-agent": "^5.0.0", - "make-dir": "^3.1.0", "node-fetch": "^2.6.7", "nopt": "^7.2.1", "npmlog": "^7.0.1",