Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Maputnik style editor into the Martin binary #852

Open
nyurik opened this issue Aug 30, 2023 · 4 comments
Open

Include Maputnik style editor into the Martin binary #852

nyurik opened this issue Aug 30, 2023 · 4 comments

Comments

@nyurik
Copy link
Member

nyurik commented Aug 30, 2023

maputnik is an excellent style editor (now part of maplibre), but it is often complicated to combine maputnik with martin due to CORS. It is possible to combine them via docker compose and an nginx reverse proxy, but that's also combersome and complicated for novice users.

I think we should use actix_web_static_files or similar to build+package maputnik as part of the build.rs script, and include it inside the martin binary.

@sharkAndshark
Copy link
Collaborator

sharkAndshark commented Aug 30, 2023

maputnik is awesome, I like it. But what's the reason to include it in martin?
What's the link / integration between two parts? Is something in future like this?

  • The included maputnik can show all sources in martin by default?
  • The inclded maputnik can upload styles && assests to martin?

@nyurik
Copy link
Member Author

nyurik commented Aug 30, 2023

I think it would be awesome if maputnik would be able to show the catalog content, including at some point the list of sprites and once implemented - fonts.

I am not sure if maputnik should upload anything. I still see Maputnik as somewhat of an elaborate playground for martin data - e.g. you can try out what data is available, try to style it differently, experiment with it, but later you would still save the style to your own site... TBD i guess

@NH-RedAnt
Copy link

I've been exploring both of these tools for a project I'm working on.

I'm having one odd problem using these tools together that I am about to generate an issue for. Honestly I don't know which side has the problem.

My goto toolset is python. To work around the CORS issue I created a tiny Flask app that really just serves up a static folder tree. From it I serve a MapLibreGL view and the style.json files. Enabling CORS lets me use everything locally to 3 different ports.

By the way after alots of looking at various MBTile servers, martin really just worked out of the box. Great job! Nothing else works as well for me.

@nyurik
Copy link
Member Author

nyurik commented Mar 17, 2024

FYI, Maputnik has been moved to maplibre, and so is the maplibre-gl-inspect, with lots of work being done on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants