-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New method: flip #315
Comments
Yes, flip and also normalizing to a canonical subject or object Id space |
@hrshdhgd from a priority perspective this comes after oak-synonimizer and monarch-initiative/mondo-ingest#78. |
I second this proposal and was actually about to open a ticket to request such a feature. Being able to automatically “flip” a mapping set would be helpful for the Uberon/CL-to-taxon-specific-ontology mappings, if we plan (as was the idea) to allow for them to be managed either on the Uberon/CL side or on the taxon-specific side, because we might then have to deal with mapping sets that are in a different “direction” (Uberon-maintained mappings would likely be using Uberon terms as subjects and the foreign terms as objects, whereas externally maintained mappings would likely be the other way round). |
Its in the high priority issues and will be addressed before end of March I think |
Do we agree on how the For me, it should be:
Makes sense? |
We have a draft document for this here: https://mapping-commons.github.io/sssom/chaining_rules/ Feel free to review and give feedback! |
Proposal to add rules for these predicates: mapping-commons/sssom#261 |
@kevinscharper noted in monarch-initiative/monarch-app#721 that if you are not careful and "blindly apply" a mapping file to a dataset, you may end up applying it the wrong way. For example, Mondo SSSOM mappings have Mondo IDs in as
subject_id
and external ID's such as OMIM asobject_id
s.I propose the development of a
flip
method that allows to swapsubject
andobject
. This is not just about "flipping IDs", you have tosubject
andobject
specific fields are flipped accordingly, andThis method could be useful, I think, because it allows us to centralise the logic by which we permit flipping. For example, we can simply ignore cases where flipping would be clearly wrong, or the "inverse" properties are not known.
The text was updated successfully, but these errors were encountered: