Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom 9 tile has excessive landuse, other layer details #583

Closed
nvkelso opened this issue Mar 9, 2016 · 9 comments
Closed

zoom 9 tile has excessive landuse, other layer details #583

nvkelso opened this issue Mar 9, 2016 · 9 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Mar 9, 2016

http://vector.mapzen.com/osm/all/9/245/166.topojson?api_key=vector-tiles-HqUVidw

There are many tiny landuse features included in this tile.

  • The large ones should keep their names and independent existence.
  • The smaller ones should loose their names and be merged (like what we started doing in the roads layer in v0.7).
@nvkelso
Copy link
Member Author

nvkelso commented Mar 9, 2016

Download: 9:245:166.topojson.json.zip

@nvkelso
Copy link
Member Author

nvkelso commented Mar 28, 2016

Separate tile previewed in QGIS:

screen shot 2016-03-28 at 13 31 07

22.json.zip

For instance, all the Urban Area polygons from Natural Earth at the same min_zoom and sort_key could be merged.

@nvkelso
Copy link
Member Author

nvkelso commented Mar 28, 2016

I suspect the roads and boundary layers need additional geom simplifying.

We could also strip some properties off the boundary layer at low zooms (like name and the name variants) at zooms less than 8 as the zoom isn't large enough to provide screen space to do the labeling.

screen shot 2016-03-28 at 13 35 53

screen shot 2016-03-28 at 13 35 24

@nvkelso nvkelso changed the title zoom 9 tile has excessive landuse zoom 9 tile has excessive landuse, other layer details Mar 28, 2016
@nvkelso nvkelso added this to the v0.10.0 milestone Mar 28, 2016
@zerebubuth
Copy link
Member

Tracking changes for the linework in roads and boundaries layers in #641 - no need to conflate that task, which is about altering a threshold for a feature we already have, and this one which is about adding an entirely new feature.

@nvkelso
Copy link
Member Author

nvkelso commented Aug 3, 2016

Establish some scale ranks for landuse

From queries.yaml, these are already applied, but the CSV is empty now.

The sizes will be similar to how buildings.csv is setup, but you'll use some of the area thresholds from other filters.

You'll need to create a new merge function, similar to roads and buildings, using the scalerank and the tier values.

@nvkelso
Copy link
Member Author

nvkelso commented Aug 3, 2016

See issue #473 for landuse tiers, and scale rank recommendations (there are pasted filter values there).

@nvkelso
Copy link
Member Author

nvkelso commented Aug 3, 2016

Perhaps use #202 to set different area threshold per kind? @rmarianski how would @okavvada do that?

@rmarianski
Copy link
Member

Yes, we can use several approaches, and even all of them together. I'll put in pointers to the different pieces.

  1. Assign scalerank using the spreadsheet.
  2. To drop features that aren't a minimum size, update the mz_min_pixels spreadsheet. We already have a transform configured that drops the features that don't meet the mz_min_pixels threshold, so updating the spreadsheet is all that's required. Remember to restart tileserver after making updates to this file.
  3. Here's the building merge transform. We also have one to merge roads, that is slightly different.
    Sounds like the criteria here is slightly different, in the sense that we want to drop the name property but only for features that don't meet an area threshold, but the rest should be similar to the buildings merge.
    I'd suggest making a new transform to get this working first, and then perhaps in a separate future issue we can see if it's possible to unify all these merges together.

By the way, if we're going to merge, it might be safer not to drop any features.

@nvkelso
Copy link
Member Author

nvkelso commented Sep 9, 2016

Wow! This is fantastic – I'm seeing improvements in less features and smaller file sizes at all zoom levels!

But at low zooms we still have individual tile features for national_park features but I expected to only see merged "generic" polygons within the kind.

Since work in this issue gave us a huge win and additional merging is not backwards incompatible, let's track additional work in #1033.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants