Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for rxdb-internal-types.ts #2

Closed
marceljuenemann opened this issue Apr 3, 2023 · 1 comment
Closed

Remove need for rxdb-internal-types.ts #2

marceljuenemann opened this issue Apr 3, 2023 · 1 comment

Comments

@marceljuenemann
Copy link
Owner

rxdb-internal-types.ts currently contains some types copied from RxDB. Two options:

  1. Ask RxDB to add those types to their exports
  2. Don't reference those types at all and just copy the fields into SupabaseReplicationOptions. This might actually be good for readability, and we are already documenting all options in the README anyways. The only downside is that if RxDB adds a new option, it won't automatically become part of our API, but rather will need to be added explicitly. Although arguably, that might also not be the worst anyways in order to make sure any option is actually supported by us (e.g. waitForLeadership is not supported)
@marceljuenemann
Copy link
Owner Author

Filed RxDB issue here: pubkey/rxdb#4606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant