Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling mark on line 1015 #1

Closed
vygr opened this issue Sep 15, 2016 · 1 comment
Closed

Calling mark on line 1015 #1

vygr opened this issue Sep 15, 2016 · 1 comment

Comments

@vygr
Copy link

vygr commented Sep 15, 2016

Hi, nice project. Reminds me somewhat of the Jones Forth but for Lisp. :)

Looking through the source, on line 1015 your calling mark which ends up marking the object in r2. That object has been placed on the stack, so on calling collect garbage it will be marked anyways.

So I think you can remove that call. Very minor issue I know, but proves I'm paying attention. :) or missing something subtle...

Best regards

Chris

@marcpaq
Copy link
Owner

marcpaq commented Sep 16, 2016

Hi Chris,

Thanks for the compliment and the sharp eye. Yes, I can and did remove that call.

Fixed.

Marc.

@marcpaq marcpaq closed this as completed Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants