Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertionResults empty #59

Open
nhomble opened this issue Aug 1, 2024 · 2 comments
Open

assertionResults empty #59

nhomble opened this issue Aug 1, 2024 · 2 comments

Comments

@nhomble
Copy link

nhomble commented Aug 1, 2024

I am trying to figure out why this happens, but my nil check on my fork has unblocked me.

Unless other folks have seen this before, I am going to wait to submit a pull request once I understand the root cause a little better to justify the check.

@nhomble
Copy link
Author

nhomble commented Aug 1, 2024

FWIW the types claim we shouldn't get nil, https://github.com/vitest-dev/vitest/blob/main/packages/vitest/src/node/reporters/json.ts#L47

I'll keep this open in case anyone else in the community has encountered this.

@nhomble
Copy link
Author

nhomble commented Aug 2, 2024

🤦 when you're on an ancient version of vitest then yeah it makes sense certain fields were added later: https://github.com/vitest-dev/vitest/blob/v0.3.5/packages/vitest/src/node/reporters/json.ts#L9

Since the plugin works without this additional metadata, I think it's nice-to-have but realistically any actual user of vitest is going to be on version with this in the json reporter

@nhomble nhomble mentioned this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant