Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isdir() vs ZipInfo.is_dir() #44

Closed
radek00p opened this issue Mar 12, 2018 · 4 comments
Closed

isdir() vs ZipInfo.is_dir() #44

radek00p opened this issue Mar 12, 2018 · 4 comments

Comments

@radek00p
Copy link

Hello,

Would that be possible to improve zipfile-compatibility when it comes to 'isdir()' method?
In ZipInfo class the equivalent is 'is_dir()'.

Thank you.
radek

@rmspeers
Copy link

@markokr would you merge a PR if I provided one to make this change?

@piskvorky
Copy link

piskvorky commented Jun 30, 2019

Also bitten by this.

The rarfile documentation says The interface is made as zipfile-like as possible., so this was an unexpected surprise.

@rmspeers @radek00p did you find any other instances of differing API, apart from is_dir vs isdir?

@piskvorky
Copy link

piskvorky commented Jun 30, 2019

Gah, found one more: ZipFile.open(pwd=None) vs RarFile.open(psw=None) (subtly different name of the optional password parameter).

@piskvorky
Copy link

piskvorky commented Jan 12, 2022

@markokr is the pwd / psw resolved as well now? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants