Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCP-4161 Draft of on-chain specification for Marlowe validators. #221

Merged
merged 8 commits into from
Aug 24, 2022
Merged

SCP-4161 Draft of on-chain specification for Marlowe validators. #221

merged 8 commits into from
Aug 24, 2022

Conversation

bwbush
Copy link
Collaborator

@bwbush bwbush commented Aug 10, 2022 •
edited
Loading

Please attend to the following items in this review:

  • Is sufficient context provided?
  • Is the notation clear?
  • Are any on-chain constraints/requirements missing or incorrect?
  • Are the constraints explained in sufficient detail?
  • Is the specification's location the best folder for it?
  • Should a CIP-52 section be added?

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@bwbush bwbush requested a review from palas August 10, 2022 19:21
@bwbush bwbush self-assigned this Aug 10, 2022
@bwbush bwbush changed the base branch from main to cardano-node-1.35 August 11, 2022 12:31
palas
palas requested changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks really good, and it did help me understand the implementation much better :)
I still didn't understand the diagram 100%, but I think the legend addition could help, and also being familiar with Plutus datatypes probably helps too

simonjohnthompson
simonjohnthompson reviewed Aug 15, 2022
View reviewed changes
Copy link
Member

@simonjohnthompson simonjohnthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I added some comments.

bwbush and others added 2 commits August 15, 2022 08:32
@bwbush bwbush requested a review from paluh August 15, 2022 15:21
palas
palas approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good

@bwbush bwbush merged commit a3aafbf into cardano-node-1.35 Aug 24, 2022
@bwbush bwbush deleted the SCP-4161 branch August 24, 2022 11:35
ladamesny pushed a commit that referenced this pull request Aug 24, 2022
@bwbush @ladamesny
SCP-4161 Draft of on-chain specification for Marlowe validators. (#221)
39f84de 
SCP-4161 Draft of on-chain specification for Marlowe validators.

* Clarification text regarding application of inputs.
* Fixed grammar.
* Additional clarifications.
* Typos fixed.
* Addressed reviewer comments in PR #221.
* Edited diagram, per comments on PR #221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paluh paluh paluh left review comments

@simonjohnthompson simonjohnthompson simonjohnthompson left review comments

@hrajchert hrajchert hrajchert left review comments

@palas palas palas approved these changes

Assignees

@bwbush bwbush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bwbush @paluh @simonjohnthompson @palas @hrajchert