Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future versions - tagging standards #1244

Closed
troyxmccall opened this issue Feb 3, 2024 · 1 comment
Closed

future versions - tagging standards #1244

troyxmccall opened this issue Feb 3, 2024 · 1 comment

Comments

@troyxmccall
Copy link

hi @marocchino

first of all, thank you for this plugin, I use it in my daily PR workflow

would you consider bumping your major version with the new Node release for future GitHub Action Releases?

aka: https://github.com/actions/checkout/releases released a new major version (v4) for Node20 support

When you bumped https://github.com/marocchino/sticky-pull-request-comment/releases/tag/v2.9.0

to Node v20, those of us on self-hosted runners running marocchino/sticky-pull-request-comment@v2

that don't support Node20 (actions/runner#2906) experienced a breaking change

of course, the workaround for this breaking change would be for users to move their workflow to a secondary job that runs on a runner that supports Nodev20:

  post-release-details:
   runs-on: ubuntu-latest # Nodev20 support needed for these steps
   needs: checkout-and-build-site
   if: github.actor!= 'dependabot-preview[bot]'   # ignore the pull request which comes from user depbot.
   steps:
     # get vars to pass on later
     - uses: FranzDiebold/github-env-vars-action@v2
     - name: Extract branch name
       shell: bash
       run: echo "branch=$(echo ${CI_ACTION_REF_NAME_SLUG})" >> $GITHUB_OUTPUT
       id: extract_branch

     - name: post comment to PR
       uses: marocchino/sticky-pull-request-comment@v2
       with:
         recreate: true
         message: |
           Release ${{ github.sha }} has been built on <https://${{ steps.extract_branch.outputs.branch }}.example.dev>

but it'd be great for future major releases to stick to their (assigned) node versions for unique runtimes

Thanks!

@marocchino
Copy link
Owner

Since I always use the latest version, I didn't even think about that.
Okay, I'll upload the major version next time. thank you for telling me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants