Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResizeObserver-based fitting observer #96

Closed
yhatt opened this issue Jul 11, 2019 · 1 comment · Fixed by #263 or #264
Closed

ResizeObserver-based fitting observer #96

yhatt opened this issue Jul 11, 2019 · 1 comment · Fixed by #263 or #264
Labels
enhancement New feature or request

Comments

@yhatt
Copy link
Member

yhatt commented Jul 11, 2019

Currently we use polling-based observation for fitting header. It tracks the change of size includes CSS animation certainly, but it has a big effect to the performance.

Chrome >= 64 is supported ResizeObserver to observe change the size of element with better performance. It has better to use it if possible.

@yhatt
Copy link
Member Author

yhatt commented Apr 16, 2020

Safari 13.1 had shipped at this month, and now all modern browsers have implemented ResizeObserver. We may start working for new implementation of auto scaling.

If completed, the current polling-based logic would only use as fallback.

@yhatt yhatt added the enhancement New feature or request label Apr 18, 2020
This was linked to pull requests Oct 29, 2021
@yhatt yhatt moved this to Done ✅ in Marp Roadmap Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
1 participant