Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My custom theme doesn´t affect vscode preview presentation #100

Closed
rossii123 opened this issue Nov 12, 2019 · 10 comments · Fixed by #103
Closed

My custom theme doesn´t affect vscode preview presentation #100

rossii123 opened this issue Nov 12, 2019 · 10 comments · Fixed by #103
Labels
bug Something isn't working

Comments

@rossii123
Copy link

I have followed the instruction on how to add a custom theme in the readme file. But the css changes I write on my your-theme.css does not affect vscodes preview presentation. But my theme will appear if I export my .md file to pdf.
My vscode version is:
Version: 1.40.0
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.

@yhatt
Copy link
Member

yhatt commented Nov 13, 2019

Are there any error outputs in VS Code developer console (Ctrl/Cmd+Shift+I)?

@rossii123
Copy link
Author

I made it work on vscode version 1.39 but when we updated to 1.40 it stop working. We have tried on two computers. The console output was:

[Extension Host] Fetching theme CSS: /cool.css
console.ts:137 [Extension Host] Error: ENOENT: no such file or directory, open '/cool.css'

I disabled all my pluggins expect the marp extension when testing this.

@yhatt
Copy link
Member

yhatt commented Nov 13, 2019

Thanks to provide useful infos. The path resolution might be broken since 1.40. (It seems to resolve the relative path from /)

@yhatt yhatt added the bug Something isn't working label Nov 13, 2019
@rossii123
Copy link
Author

Nice! Then I will use the absolute path to the css file for now. The marp extension is awesome!

@yhatt
Copy link
Member

yhatt commented Nov 14, 2019

We had used a messy hack for resolution logic so could not resolve this at the moment. I've sent feedback to VS Code (microsoft/vscode#84846).

@yhatt
Copy link
Member

yhatt commented Nov 17, 2019

I've applied workaround in #103. It will be fixed in next patched version.

@yumoraby
Copy link

Has this issue been fixed, as whenever i update the CSS, i need to restart VSCode to see the changes. However changing inbuilt themes have no issues.

@Nopzen

This comment has been minimized.

@yhatt

This comment has been minimized.

@Nopzen

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants