Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should sync rendering setting with markdown.math.enabled? #256

Closed
yhatt opened this issue Jul 7, 2021 · 1 comment · Fixed by #258
Closed

Should sync rendering setting with markdown.math.enabled? #256

yhatt opened this issue Jul 7, 2021 · 1 comment · Fixed by #258

Comments

@yhatt
Copy link
Member

yhatt commented Jul 7, 2021

VS Code 1.58 will add a built-in math typesetting support for Markdown Preview with KaTeX. User can preview math typesetting in Markdown without any extensions.

Luckily this rendering would not conflict with Marp's math support, and there is high compatibllity with Marp syntax.

Math rendering can disable through markdown.math.enabled setting. Marp for VS Code is extending built-in preview, so following this setting even in Marp preview may be reasonable when keep to mental model of Markdown preview, just like #226.

On the other hand, Marp supports KaTeX and MathJax as typesetting library and user can choose one of which. The difference of functionality for math rendering between VS Code preview and Marp may become large with advances. Thus, keeping split setting like the relation between markdown.preview.breaks and markdown.marp.breaks may be better too. (In this case, we would add markdown.marp.mathTypesetting: "off" option to disable math, for following the use case of markdown.math.enabled)

@yhatt
Copy link
Member Author

yhatt commented Jul 8, 2021

We are going to take the latter in #258.

@yhatt yhatt closed this as completed in #258 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant