Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the export command while non-file schema #262

Closed
yhatt opened this issue Jul 20, 2021 · 0 comments · Fixed by #269
Closed

Handle the export command while non-file schema #262

yhatt opened this issue Jul 20, 2021 · 0 comments · Fixed by #269

Comments

@yhatt
Copy link
Member

yhatt commented Jul 20, 2021

The export command assumes to save into local file (file:///c:/xxx). On the other hand, Marp for VS Code is also working on remote container (e.g. vscode-remote:// schema such as Docker container, SSH, and WSL). In this case, the export command may try to save into the host filesystem vscode-local:// which is not known by CLI if selected Show locals in the save dialog.

We should consider one of them:

  1. Simply output error if detected non-file schema in the path for save.
  2. Handle the path to the host of container (Export to a temporal file and save to the host through VS Code API)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant