Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export with custome theme broken in 1.4.1 and 1.4.2 #302

Closed
dwschmid opened this issue Oct 6, 2021 · 2 comments · Fixed by #303
Closed

Export with custome theme broken in 1.4.1 and 1.4.2 #302

dwschmid opened this issue Oct 6, 2021 · 2 comments · Fixed by #303
Labels
bug Something isn't working

Comments

@dwschmid
Copy link

dwschmid commented Oct 6, 2021 •
edited
Loading

My custom theme residing in a local subfolder .css (added through settings.json) works in the VSCODE preview in 1.4.0 to 1.4.2. However, when I want to export as HTML or PDF then the custom theme stuff does not seem to be respected in 1.4.1 and 1.4.2. Reverting to 1.4.0 makes this work again.
@yhatt yhatt added the bug Something isn't working label Oct 6, 2021
@yhatt yhatt mentioned this issue Oct 6, 2021
Merged
@yhatt yhatt closed this as completed in #303 Oct 6, 2021
@yhatt
Copy link
Member

yhatt commented Oct 6, 2021

That was a regression brought by our refactor for supporting Web extension. We have just rolled out a fixed version v1.4.3. Thanks for your report 😄

@dwschmid
Copy link
Author

dwschmid commented Oct 6, 2021

thanks!

@sgudenkauf sgudenkauf mentioned this issue Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression about export with local custom theme marp-team/marp-vscode
2 participants
@yhatt @dwschmid