-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TracksList supports several time the same track #112
Comments
I think it's a good idea, but I would not like to have several times the same track in the same playlist. Or at least notify a warning when a duplicate is added. |
That's an interesting point of view, why do you think there should be no duplicate ? |
Why a playlist should have duplicates? I don't get the point of having that. Take the following example : Avoiding that would be a great help in my opinion. But it's a matter of taste. Maybe we can use a setting flag to disable/enable duplicates in playlists. |
My two cents: telling it's a duplicate and asking the user to ask it anyway seems like the right way to go. Just refusing to let the user add a song because it's a duplicate would be frustrating. You don't know why someone wants the same song twice in a playlist - maybe they're trying to start the set with the same song or some similar reason, but it's not obvious that it's a mistake. But you also want to let them know, just in case. |
@simonv3 Do you suggest there should be a warning when a duplicate is added to a playlist or do you suggest to allow multiple times the same track in playlists ? |
Pop up a warning before adding it, but let them add the songs if they want to. "These songs already exists in the playlist, are you sure?" |
I will close this as I don't plan to support it soon, and as discussed, it may not make a lot of sense. |
TracksList
only support unique_id
tracks, there can't be several time the same track on a list, otherwise weird things happens:This blocks multiple features like:
We also have to think about making it reorderable with an option for playlists. Different issue, but we have to keep that in mind.
The text was updated successfully, but these errors were encountered: