Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TracksList supports several time the same track #112

Closed
martpie opened this issue Jul 15, 2016 · 7 comments
Closed

Make TracksList supports several time the same track #112

martpie opened this issue Jul 15, 2016 · 7 comments

Comments

@martpie
Copy link
Owner

martpie commented Jul 15, 2016

TracksList only support unique _id tracks, there can't be several time the same track on a list, otherwise weird things happens:

  • Tracks selection goes mad
  • Now playing indicator goes mad

This blocks multiple features like:

  • Playlist with several time the same track in it

We also have to think about making it reorderable with an option for playlists. Different issue, but we have to keep that in mind.

@cfollet
Copy link
Contributor

cfollet commented Sep 16, 2016

I think it's a good idea, but I would not like to have several times the same track in the same playlist. Or at least notify a warning when a duplicate is added.

@martpie
Copy link
Owner Author

martpie commented Sep 16, 2016

That's an interesting point of view, why do you think there should be no duplicate ?

@cfollet
Copy link
Contributor

cfollet commented Sep 17, 2016

Why a playlist should have duplicates? I don't get the point of having that.
I mean, iTunes/MusicBee/Spotify/SoundCloud warn you or don't allow you to have duplicates in playlist.

Take the following example :
If you listen to a song that goes perfectly well in one of your playlists. You will add it in. Few months after, you will listen to this track again and, of course, it still goes perfectly well into that playlist. But you don't remember that is it already in. So you will add it again ... and again.

Avoiding that would be a great help in my opinion. But it's a matter of taste. Maybe we can use a setting flag to disable/enable duplicates in playlists.

@simonv3
Copy link

simonv3 commented Oct 21, 2016

My two cents: telling it's a duplicate and asking the user to ask it anyway seems like the right way to go.

Just refusing to let the user add a song because it's a duplicate would be frustrating. You don't know why someone wants the same song twice in a playlist - maybe they're trying to start the set with the same song or some similar reason, but it's not obvious that it's a mistake. But you also want to let them know, just in case.

@martpie
Copy link
Owner Author

martpie commented Oct 21, 2016

@simonv3 Do you suggest there should be a warning when a duplicate is added to a playlist or do you suggest to allow multiple times the same track in playlists ?

@simonv3
Copy link

simonv3 commented Oct 21, 2016

Pop up a warning before adding it, but let them add the songs if they want to.

"These songs already exists in the playlist, are you sure?"
options: "Add duplicates" "Skip duplicates"

@martpie
Copy link
Owner Author

martpie commented Aug 19, 2018

I will close this as I don't plan to support it soon, and as discussed, it may not make a lot of sense.

@martpie martpie closed this as completed Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants