Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember tracks list scroll position when switching views #519

Closed
ldexterldesign opened this issue Mar 2, 2020 · 8 comments · Fixed by #786
Closed

Remember tracks list scroll position when switching views #519

ldexterldesign opened this issue Mar 2, 2020 · 8 comments · Fixed by #786
Milestone

Comments

@ldexterldesign
Copy link

ldexterldesign commented Mar 2, 2020

Hi!

Hope you're well

Thanks for wonderful software

As a user, when I switch/tab between Library, Playlist and Setting views, I want states to persist instead of defaulting to the top of the view (i.e. first track in list) so I don't have to scroll back to my previous state (e.g. a track half way down my list)

Steps to reproduce issue

  1. Click (i.e. play) a track in Library, preferably something one had to scroll the view to find
  2. Navigate to another view (e.g. Playlists/Settings)
  3. Navigate back to Library

Unexpected behaviour

Library view shows top of view

Expected behaviour

Library view shows the track I clicked to play before I left the view

If you're reading and:

  • agree, then please vote up (e.g. +1, like), or;
  • disagree, then please vote down (e.g. -1, dislike) - I'd love to know why?

If you have any issues (e.g. questions/queries) then happy to help

Keep up great work!

Sincerely

hardware: Apple, MacBook Pro (16-inch, 2019)
software - operating system: Apple, macOS, 10.15.3 (19D76)
software - application: Museeks, 0.11.3 (0.11.3)

@ldexterldesign ldexterldesign changed the title I want Library, Playlists and Settings views states to persist instead of defaulting to the top #Enhancement #Suggestion I want Library, Playlists and Settings views states to persist instead of defaulting to top #Enhancement #Suggestion Mar 2, 2020
@qcasey
Copy link
Contributor

qcasey commented Mar 2, 2020

I completely agree, this would be nice

@qcasey
Copy link
Contributor

qcasey commented Mar 2, 2020

What I found regarding react-router-dom:

https://reacttraining.com/react-router/web/guides/scroll-restoration/generic-solution

@martpie
Copy link
Owner

martpie commented Mar 2, 2020

Scroll restoration won't work here as the scroll is not on the whole page but on a nested element.

I agree it should be done.

ps: careful with the phrasing, please don't be rude.

@martpie martpie changed the title I want Library, Playlists and Settings views states to persist instead of defaulting to top #Enhancement #Suggestion Remember tracks list scroll position when switching views Mar 2, 2020
@ldexterldesign
Copy link
Author

ldexterldesign commented Mar 2, 2020

ps: careful with the phrasing, please don't be rude.

Screenshot 2020-03-02 at 22 25 34

https://en.wikipedia.org/wiki/User_story#Principle

😁

@ldexterldesign
Copy link
Author

ldexterldesign commented Apr 6, 2020

🙏

In the meantime, if it's easier to implement then could simply make the currently playing track more obvious (e.g. persist highlighting of the row):

Screenshot 2020-04-06 at 19 19 27

This animated icon is really hard to find:

Screenshot 2020-04-06 at 19 12 46

Persisting the view's (scroll) position could be next

Sincerely

@martpie
Copy link
Owner

martpie commented Jan 24, 2021

a question for everyone here: do you want it to remember the scroll position? Or what you want is actually it automatically scrolls to the playing track?

@ldexterldesign
Copy link
Author

ldexterldesign commented Jan 24, 2021

@martpie

Remember scroll position would close this issue for me

Scroll to playing track is useful in some use cases but annoying in other use cases (e.g. I'm interacting with some non-playing tracks, adding to playlist etc. and then the view automatically scrolls away and I have to scroll back) so I would like an option to enable (default IMO) / disable that

Hope this helps

Sincerely

@martpie
Copy link
Owner

martpie commented May 30, 2023

Waiting on remix-run/react-router#10468 to implement this. I'll definitely implement that as soon as the upstread PR gets merged and we have this available as a new API.

@martpie martpie added this to the 0.14 milestone May 30, 2023
@martpie martpie modified the milestones: 0.14, 0.20 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants