-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember tracks list scroll position when switching views #519
Comments
I completely agree, this would be nice |
What I found regarding react-router-dom: https://reacttraining.com/react-router/web/guides/scroll-restoration/generic-solution |
Scroll restoration won't work here as the scroll is not on the whole page but on a nested element. I agree it should be done. ps: careful with the phrasing, please don't be rude. |
https://en.wikipedia.org/wiki/User_story#Principle 😁 |
a question for everyone here: do you want it to remember the scroll position? Or what you want is actually it automatically scrolls to the playing track? |
Remember scroll position would close this issue for me Scroll to playing track is useful in some use cases but annoying in other use cases (e.g. I'm interacting with some non-playing tracks, adding to playlist etc. and then the view automatically scrolls away and I have to scroll back) so I would like an option to enable (default IMO) / disable that Hope this helps Sincerely |
Waiting on remix-run/react-router#10468 to implement this. I'll definitely implement that as soon as the upstread PR gets merged and we have this available as a new API. |
Hi!
Hope you're well
Thanks for wonderful software
As a user, when I switch/tab between Library, Playlist and Setting views, I want states to persist instead of defaulting to the top of the view (i.e. first track in list) so I don't have to scroll back to my previous state (e.g. a track half way down my list)
Steps to reproduce issue
Unexpected behaviour
Library view shows top of view
Expected behaviour
Library view shows the track I clicked to play before I left the view
If you're reading and:
If you have any issues (e.g. questions/queries) then happy to help
Keep up great work!
Sincerely
hardware: Apple, MacBook Pro (16-inch, 2019)
software - operating system: Apple, macOS, 10.15.3 (19D76)
software - application: Museeks, 0.11.3 (0.11.3)
The text was updated successfully, but these errors were encountered: